Bug 6594 - AIX and sys_getgrouplist
Summary: AIX and sys_getgrouplist
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.4
Classification: Unclassified
Component: File services (show other bugs)
Version: 3.4.0
Hardware: PPC AIX
: P3 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-31 05:04 UTC by Yannick Bergeron
Modified: 2009-08-03 09:12 UTC (History)
1 user (show)

See Also:


Attachments
git patch against origin/v3-4-test (834 bytes, patch)
2009-07-31 05:04 UTC, Yannick Bergeron
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yannick Bergeron 2009-07-31 05:04:10 UTC
Problem is the same described on this mailing list a few years ago (AIX 5.3 and AIX 6.1)
http://lists.samba.org/archive/samba-technical/2006-September/049234.html

ie:
"As it was detected during debug sessions and using special traces, in this
case the initgroups() function coming from the own libraries of AIX is
writing to some memory areas, where it shouldn't"

but the solution described is not good for my needs because rep_initgroups only fetch local groups and my DCE + GPFS setup needs the DCE groups. Figured that calling sys_getgrouplist only once is a better choice so the following patch has been pushed to master. I would appreciate it to be added to 3.3 and 3.4 as well
Comment 1 Yannick Bergeron 2009-07-31 05:04:46 UTC
Created attachment 4495 [details]
git patch against origin/v3-4-test
Comment 2 Volker Lendecke 2009-07-31 05:07:38 UTC
Ack from my side. Patch also applies for me with "git am -3" in v3-3-test.

Volker
Comment 3 Michael Adam 2009-07-31 05:21:07 UTC
In principle, we could add a configure check for the broken aix call
and do a workaround if it is found broken.

But until we have this, I think this is a fair compromize.
Raising the potential minimum of groups to 128 does not harm any one.

+1 from me
Comment 4 Yannick Bergeron 2009-07-31 10:46:52 UTC
Michael, I have tried to reproduce the problem with a simple test code and haven't been able to. This is why I've waited since the first mailing-list post about it and yesterday because I was trying to reproduce it on my free time
Comment 5 Karolin Seeger 2009-08-03 09:12:34 UTC
Pushed. Patch will be included in 3.3.8 and 3.4.1.
Closing out bug report.

Thanks!