Bug 6565 - [PATCH] lib/util/util_file.c: possible resource leak in file_save() functions
Summary: [PATCH] lib/util/util_file.c: possible resource leak in file_save() functions
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All All
: P3 minor (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Matthias Dieter Wallnöfer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-18 04:33 UTC by Slava Semushin
Modified: 2009-07-20 02:13 UTC (History)
0 users

See Also:

Attachments
Proposal fix (787 bytes, patch)
2009-07-18 04:35 UTC, Slava Semushin 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Slava Semushin 2009-07-18 04:33:58 UTC 
I found one possible memory leak with cppcheck in lib/util/util_file.c. When read(2) fails file descriptor not closes.

Patch in attach.
Comment 1 Slava Semushin 2009-07-18 04:35:01 UTC 
Created attachment 4444 [details]
Proposal fix
Comment 2 Matthias Dieter Wallnöfer 2009-07-20 02:13:22 UTC 
Fixed in branch "master".