Bug 6550 - Samba needs to dynamically track user/registry share permission changes
Summary: Samba needs to dynamically track user/registry share permission changes
Status: NEW
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All Linux
: P3 enhancement
Target Milestone: ---
Assignee: Volker Lendecke
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-14 13:28 UTC by Jeremy Allison
Modified: 2010-01-25 05:29 UTC (History)
0 users

See Also:


Attachments
Initial patch from Boyang to add this functionality. (15.56 KB, patch)
2009-07-14 13:29 UTC, Jeremy Allison
no flags Details
trace (67.95 KB, patch)
2009-07-14 22:14 UTC, boyang
no flags Details
new patch (15.41 KB, text/x-patch)
2009-07-16 13:44 UTC, boyang
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2009-07-14 13:28:44 UTC
Windows seems to track share permission changes and modify existing connections accordingly. We need to do the same.

Jeremy.
Comment 1 Jeremy Allison 2009-07-14 13:29:29 UTC
Created attachment 4415 [details]
Initial patch from Boyang to add this functionality.
Comment 2 boyang 2009-07-14 22:14:23 UTC
Created attachment 4419 [details]
trace

packet trace. :-)

The tid 0x0040 is always there if user has some kind of access right. this is from write to read change. I cannot see another tconx to share usershare.

Please correct me if I am wrong.
Comment 3 Volker Lendecke 2009-07-15 01:13:01 UTC
Hmmm. What I would like to see is a torture test that opens a file r/w, does a write, opens a second connection and changes the share secdesc, then proves the existing file handle is changed by trying another write, then getting refused. To be honest, I still don't really believe this happens. A torture test that can easily be run would certainly be very convincing.

Thanks,

Volker
Comment 4 boyang 2009-07-16 13:44:04 UTC
Created attachment 4433 [details]
new patch

improved patch to use poll-style check. unfinished, under reviewing.. :-)
Comment 5 Volker Lendecke 2009-07-28 03:14:23 UTC
Bo, any updates on the torture test I asked for?

Volker
Comment 6 Karolin Seeger 2010-01-25 05:29:11 UTC
Too late for enhancements in 3.5. Raising version.