Bug 6521 - configure detection for sysquota support fails
configure detection for sysquota support fails
Status: RESOLVED FIXED
Product: Samba 3.4
Classification: Unclassified
Component: Build environment
3.4.0rc1
Other Linux
: P3 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-30 06:40 UTC by Michael Adam
Modified: 2009-07-01 06:23 UTC (History)
1 user (show)

See Also:


Attachments
fix for 3.4, taken from master (847 bytes, patch)
2009-06-30 06:42 UTC, Michael Adam
metze: review+
Details
subsequent patch for v3-4-test that removes run time side effects (912 bytes, patch)
2009-07-01 04:38 UTC, Michael Adam
gd: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2009-06-30 06:40:10 UTC
detection for the lib/sysquota.c interface fails in current v3-4-test
because of a bug in lib/util/tevent_ntstatus.h : it includes config.h:

configure called with --with-quotas (and --with-sys-quotas=yes, but this does not make a difference). Here is the important part of config.log:

configure:73334: checking whether the sys_quota interface works
configure:73370: ccache gcc -c   -g -ggdb   -Wc++-compat   -Wcomment   -Wpointer-arith   -Wcast-align   -Wwrite-strings   -Wstrict-prototypes   -Wstrict-aliasing   -Wmiss
ing-prototypes   -Wmissing-declarations   -Wshadow   -Wdeclaration-after-statement   -D_FORTY_SOURCE=2   -fmessage-length=0  -g   -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BIT
S=64 -D_GNU_SOURCE  -Iinclude -I./include  -I. -I. -I./../lib/replace -I./../lib/talloc -I./../lib/tevent -I./../lib/tdb/include -I./libaddns -I./librpc -I./.. -I./../lib
/popt -I/usr/include -DLDAP_DEPRECATED -Iinclude -I./include  -I. -I. -I./../lib/replace -I./../lib/talloc -I./../lib/tevent -I./../lib/tdb/include -I./libaddns -I./librp
c -I./.. -I./../lib/popt conftest.c >&5
In file included from include/includes.h:581,
                 from ./lib/sysquotas_linux.c:21,
                 from conftest.c:583:
./../lib/util/tevent_ntstatus.h:25:20: error: config.h: No such file or directory
In file included from conftest.c:583:
./lib/sysquotas_linux.c:442: warning: no previous prototype for 'sys_get_vfs_quota'
...
Comment 1 Michael Adam 2009-06-30 06:42:17 UTC
Created attachment 4372 [details]
fix for 3.4, taken from master

The attached fix has already been pushed to master.
It fixes the detection.

Please review for inclusion to 3.4.0 final
Comment 2 Michael Adam 2009-06-30 06:43:32 UTC
Metze, please review for 3.4.0 inclusion.
Assign to Karolin if you think it is needed.
Comment 3 Karolin Seeger 2009-06-30 07:05:21 UTC
Pushed to v3-4-test.
Closing out bug report.

Thanks!
Comment 4 Michael Adam 2009-07-01 04:36:36 UTC
sorry, the patch had some side effects for the runtime of the binaries.
reopening the bug. (subsequent patch following immediately)
Comment 5 Michael Adam 2009-07-01 04:38:22 UTC
Created attachment 4382 [details]
subsequent patch for v3-4-test that removes run time side effects

gd please review
Comment 6 Guenther Deschner 2009-07-01 05:28:01 UTC
Comment on attachment 4382 [details]
subsequent patch for v3-4-test that removes run time side effects

looks fine.
Comment 7 Karolin Seeger 2009-07-01 06:23:47 UTC
Pushed, closing out bug report.

Thanks!