Bug 6475 - make default passdb backend configureable at compiletime
make default passdb backend configureable at compiletime
Product: Samba 3.4
Classification: Unclassified
Component: Build environment
All All
: P3 enhancement
: ---
Assigned To: Björn Jacke
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2009-06-14 11:47 UTC by Lars Müller
Modified: 2009-11-10 08:02 UTC (History)
1 user (show)

See Also:

Add --with-default-passdb-backend configure option (1.74 KB, patch)
2009-06-14 11:56 UTC, Lars Müller
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Müller 2009-06-14 11:47:52 UTC
Recently we switched the passdb backend to tdbsam as default.

This might cause trouble for users using older operating systems as soon as the vendor provides recent binaries.

This is only the case as long as the fictional user hasn't set an explicit passdb backend in the smb.conf.

Therefore I suggest to make the default passdb backend a configure option at compile time.
Comment 1 Lars Müller 2009-06-14 11:56:50 UTC
Created attachment 4286 [details]
Add --with-default-passdb-backend configure option

This patch adds the suggested global 'passdb backend' option.

It defaults to tdbsam and accepts only smbpasswd the second alternative.
Comment 2 Volker Lendecke 2009-06-15 05:05:50 UTC
Please don't do this. If you need a different default for SLES, please do that with a patch in your RPMs. If you have concerns with the new default, please bring up this discussion on samba-technical again.


Comment 3 Lars Müller 2009-06-15 05:56:37 UTC
This is not a concern about the new default.

This is about customers using Samba on older products in general.  This isn't an issue to one vendor only.

This is a very generic issue to anyone using and deploying Samba.

As soon as no 'passdb backend' is set in the old smb.conf file the users gets without intention the new default.

The new --with-default-passdb-backend configure option - which defaults to tdbsam! - allows vendors to ship updates for older products using the same default 'passdb backend' as shipped with the initial product.
Comment 4 Volker Lendecke 2009-06-15 06:22:10 UTC
Bring this up on samba-technical again.
Comment 5 Björn Jacke 2009-06-15 06:34:27 UTC
to sumarize what I said in a chat: I have objections to such a variable default
setting. When people send in the smb.conf on samba ML or bugzilla or any other
support case it will no longer suffice to see the smb.conf. An output of
testparm would be required (which again does not show parametrized options).

A major version update should not be made unattended. A major version update
always requires a good config review and a close look at the Changelog. If some
verndors decide to do unattended major version updates, then we should not mess
up in upstream because of that and make config files more worthless for support
cases. When a vendor decides for whatever reason to make unattended major
version updates (the usefullmess shouldn't be discussed here), they can modify
the config and add something like "passdb backend = smbpasswd" via post/pre
install scripts or patch their package to use a different default if they
really think this is the right thing to do. For upstream I don't think we
should allow to make cusomizable default settings.
Comment 6 Volker Lendecke 2009-06-15 06:45:13 UTC
What I'm missing here is a follow-up of the thread that lead to the changed default. Lars has the requirement that we never ever change any default in the smb.conf file, so that we don't break any upgrade.

We should really not discuss this here, it is a valid concern that a broader audience must discuss.