There's a build problem on some Distros like on some Debian systems, where strncat seems to be a macro which contains strcat and thus leads to this compile error (reported by Karo in IRC :-):
16:01 < ks> Compiling pam_smbpass/support.c
16:01 < ks> pam_smbpass/support.c: In function `_log_err':
16:01 < ks> pam_smbpass/support.c:93: error: `__ERROR__XX__NEVER_USE_STRCAT___' undeclared (first use in this
16:01 < ks> pam_smbpass/support.c:93: error: (Each undeclared identifier is reported only once
16:01 < ks> pam_smbpass/support.c:93: error: for each function it appears in.)
16:01 < ks> pam_smbpass/support.c:93: error: syntax error before ';' token
proposed patch follows...
Created attachment 4267 [details]
Hm, shouldn't we use just asprintf here ?
That's what I also proposed on irc. We would have to use talloc_asprintf, because asprintf might not be available everywhere. We did not reach consensus though.
Isn't asprintf available through libreplace ?
Do we have libreplace in pam_smbpass?
well, pam_smbpass needs to link against all of passdb, right ? In that case using asprintf here surely is not a problem.
ok, somehow this bug ended up @/me...
I think someone of you who have uttered an vote for talloc_asprintf should propose a new patch? ... :-)
Schwarzer Peter ==> gd
As this is the remaining showstopper for 3.4.0 due tomorrow I'd suggest going with the patch as-is. Any other suggestions ?
Picked Björn's patch for 3.4.0.
Günther would you still like to provide the asprintf patch or should we close the bug report?
Closing as fixed. Thanks for the patch!