Bug 6452 - Uncorrect test for password expiry
Summary: Uncorrect test for password expiry
Status: RESOLVED DUPLICATE of bug 6253
Alias: None
Product: Samba 3.4
Classification: Unclassified
Component: Winbind (show other bugs)
Version: unspecified
Hardware: All Linux
: P3 major
Target Milestone: ---
Assignee: Michael Adam
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-08 08:57 UTC by Pietro Donatini
Modified: 2009-06-17 05:57 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pietro Donatini 2009-06-08 08:57:44 UTC 
source of samba-3.4.0pre2:

in nsswitch/pam_winbind.c:917 
there is a check
(policy->expire == -1)
that can never be satified since 
policy is wbcUserPasswordPolicyInfo and 
expire is defined in nsswitch/libwbclient/wbclient.h as uint64_t.

Since an expiry of "never" is translated to the biggest number 
I think the test should be something like

(policy->expire + 1 == 0)

The same bug appears in samba 3.3.x where the check was
(policy->expire <= 0) and prevents logins 
in particular configurations with security = ADS.
Comment 1 Guenther Deschner 2009-06-17 05:57:42 UTC 
This is a duplicate, just for 3.4 (bug #6253 is for 3.3)

*** This bug has been marked as a duplicate of bug 6253 ***