The Samba-Bugzilla – Bug 6407
[CTDB] Please fix bashisms in shell scripts
Last modified: 2011-10-15 13:46:55 UTC
See attached patch.
From Debian bug: http://bugs.debian.org/530064
Created attachment 4203 [details]
Created attachment 4204 [details]
All bits except (as I just noticed) the patch to 00.ctdb have been pushed upstream and will be in 1.0.91 if I am not mistaken.
About the 00.ctdb bit:
you check for the existence of the time command with the sequence
"command -v time" .
How portable is it?
It is in bash, it is in dash (i.e. POSIX shell?)
But is it also in vanilla "sh"?
Ronnie, Mathieu, What to do about that?
(In reply to comment #4)
> About the 00.ctdb bit:
> you check for the existence of the time command with the sequence
> "command -v time" .
I don't use this part of the patch (see http://svn.debian.org/wsvn/pkg-samba/trunk/ctdb/debian/patches/50-fix-bashism.diff) as the package now installs the "time" package.
Ok, so I think we can close this bug, right.
The submitted patches will be in 1.0.91.
Mathieu - please reopen if problems persist.
There is one more in events.d/11.natgw:
- if [ "$NATGWMASTER" == "-1" ]; then
+ if [ "$NATGWMASTER" = "-1" ]; then
Created attachment 4753 [details]
Fix a bashism in 11.natgw
(In reply to comment #8)
> Created an attachment (id=4753) [details]
> Fix a bashism in 11.natgw
This has been included in 1.0.105
> This has been included in 1.0.105
Created attachment 5458 [details]
Fix some more bashisms
Reopening. https://bugzilla.samba.org/attachment.cgi?id=5458 should be applied
Done (once again)
I'm reopening this one. See attached patch 0001-Fix-bashism.patch.
Created attachment 6342 [details]
Fix bashism in config/events.d/60.ganesha
(In reply to comment #15)
> Created attachment 6342 [details]
> Fix bashism in config/events.d/60.ganesha
pushed to master.
Ronnie: This applies to the 1.2 branches.
I suggest picking it for the releases.
==> assigning to Ronnie.
Closing again: http://git.samba.org/?p=ctdb.git;a=commitdiff;h=f4d5a5810f1a840a41c3541a3b822fce44d41e9a