Bug 6320 - Changing global share default options in registry require smbd restart
Changing global share default options in registry require smbd restart
Product: Samba 3.4
Classification: Unclassified
Component: Config Files
Other Linux
: P3 normal
: ---
Assigned To: Michael Adam
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2009-05-04 08:38 UTC by Michael Adam
Modified: 2009-05-14 01:44 UTC (History)
1 user (show)

See Also:
vl: review+

patch for 3.3.4+ (3.35 KB, patch)
2009-05-12 15:47 UTC, Michael Adam
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2009-05-04 08:38:23 UTC
This applies to all Versions of Samba since 3.2.0 and to master:

When using "include = registry", changin share parameter defaults in the global registry options require a restart of smbd. They are not updated at a new share connect as they should.

I am currently working on a fix.

Comment 1 Michael Adam 2009-05-12 15:44:32 UTC
This has been fixed for 3.4 and master.
Comment 2 Michael Adam 2009-05-12 15:47:13 UTC
Created attachment 4147 [details]
patch for 3.3.4+

This is the patch for the problem, adapted for v3-3-test.
This needs to go to 3.3.5.
Please review.
Cheers - Michael
Comment 3 Volker Lendecke 2009-05-13 11:18:35 UTC
Looks good :-)

There's a way to avoid the re-indentation though, but I think it could go into 3.3 in case we want it there.

Comment 4 Michael Adam 2009-05-13 15:25:58 UTC
Right much of the patch is re-indentation.
But I liked this way better, because it makes
the logical layers more obvious (to me).
Comment 5 Karolin Seeger 2009-05-14 01:44:20 UTC
Patch is upstream (will be included in 3.3.5).

Closing out bug report.