The Samba-Bugzilla – Bug 6317
include cycles trigger infinte loop and segfault
Last modified: 2009-05-06 02:30:39 UTC
Any cycle in the config-file-tree structure (created with include statements) makes samba progams loop until a segfault happens due to exhausted stack.
This also applies to "include = registry".
This is present in all versions of Samba3, but it has already been fixed in
3.4 and master.
Created attachment 4118 [details]
patch for the bug
Attached find a git patch (mbox) comprised of two commits that fixes the bug.
To be applied with git am.
I would like to get this into the next 3.3 bugfix release.
What about just adding the pure bug-fix one to 3-3? The fact that we get 100 error messages is annoying, but it's better than smbd crashing. And I would guess that it's pretty unlikely that someone actually has this broken config around.
(In reply to comment #2)
> What about just adding the pure bug-fix one to 3-3? The fact that we get 100
> error messages is annoying, but it's better than smbd crashing. And I would
> guess that it's pretty unlikely that someone actually has this broken config
Agreed, the second patch is purely cosmetic.
Created attachment 4119 [details]
Updated git-formatted patch: just the actual bugfix without DEBUG level cosmetics.
Volker, can I take your comment #2 as +1 for the updated patch? :-)
Yes, +1 on the single one :-)
Patch is upstream. Will be included in 3.3.5.
Closing out bug report.