Bug 6266 - Samba4 installs headers into the toplevel include path by default
Summary: Samba4 installs headers into the toplevel include path by default
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Build (show other bugs)
Version: unspecified
Hardware: x64 Linux
: P3 normal (vote)
Target Milestone: ---
Assignee: Jelmer Vernooij
QA Contact:
Depends on:
Reported: 2009-04-16 03:53 UTC by David King
Modified: 2009-06-25 04:25 UTC (History)
1 user (show)

See Also:

Make --enable-fhs the default. (573 bytes, patch)
2009-04-16 04:06 UTC, David King
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David King 2009-04-16 03:53:51 UTC
Samba4 installs several headers into the toplevel include path if the --enable-fhs option is not used, e.g. util.h, charset.h, etc.. This is even acknowledged in the m4 fragment at "source4/build/m4/check_path.m4", which fails if /usr or /usr/local is given as a prefix. Rather than (trying to) hack around the issue, either --enable-fhs should be the default, or the option should be removed entirely, and only the FHS-compliant paths should be used. The same m4 fragment also acknowledges that the current default is for "legacy SAMBA directories", so I say that it is time to remove the legacy paths.
Comment 1 David King 2009-04-16 04:06:33 UTC
Created attachment 4071 [details]
Make --enable-fhs the default.
Comment 2 Matthias Dieter Wallnöfer 2009-04-16 04:48:46 UTC
Some time ago we discussed the usage of "--enable-fhs", but we came to the conclusion that it both makes sense to use (UNIX distribution packages) but also to not using it (interesting for tests).
Certainly it shouldn't happen that headers are installed in the system include directory if there hasn't been specified "--enable-fhs". My opinion is that it would be better to correct the errors in the "m4" files. Therefore please provide such a patch proposal! 
Comment 3 Matthias Dieter Wallnöfer 2009-06-19 14:55:53 UTC
Could you please point out which headers are installed in toplevel directories, so we could write a patch to fix the problem?
Comment 4 Matthias Dieter Wallnöfer 2009-06-25 04:25:49 UTC
I close this since I couldn't verify the headers which would be installed in wrong locations. If you think you are really right, please point out the lines in the files were the wrong path variables for them are located.