Bug 6169 - Syntax Error in runtests.sh "ssh-basic.test" script
Summary: Syntax Error in runtests.sh "ssh-basic.test" script
Status: RESOLVED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.0.5
Hardware: x86 Other
: P3 minor (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-06 02:06 UTC by Reiner Schulz
Modified: 2009-03-06 09:19 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Reiner Schulz 2009-03-06 02:06:10 UTC 
OS: SCO_SV imsprod 3.2 5.0.7 i386

rsync-3.0.5/testsuite/ssh-basic.test
Line 21
Original: if ! [ "`$SSH -o'BatchM...
my change: if [ ! "`$SSH -o'BatchM...

NOT-Operator at wrong place.
Comment 1 Wayne Davison 2009-03-06 09:19:32 UTC 
Whatever shell that is is broken, because '[' is just a program name (though often a built-in these days), and the syntax, "if ! program; then ... fi" is legal.  However, that "if" was a bit convoluted with a ! prior to an equality comparison, and I changed it into an inequality comparison without the prefixed "!".

Thanks!