Bug 6085 - In vfs_default.c change utime( ) call.
Summary: In vfs_default.c change utime( ) call.
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.2
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.2.4
Hardware: x86 Other
: P3 normal
Target Milestone: ---
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-03 14:14 UTC by Miguel Suarez
Modified: 2009-02-03 16:38 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Suarez 2009-02-03 14:14:50 UTC
When I compile ./source/modules/vfs_default.c (3.2.4) on VOS Operating 
System from Stratus Technologies I get: 

Compiling modules/vfs_default.c
./source/modules/vfs_default.c: In function `vfswrap_ntimes':
./source/modules/vfs_default.c:673: error: incompatible type for argument 2 of `utime'

VOS doesn't support utimes() so we use utime() instead and hit
this problem where we get compile error if we don't change:

"result = utime(path, times);" to "result = utime(path, &times);"

The 2nd arg passed into utime needs to be an address reference in 
accordance with the utime() declaration. 
 
I think this will happen on other OS'es that don't support utimes()
as well.
Comment 1 Jeremy Allison 2009-02-03 16:38:12 UTC
Fixed in all git branches. Thanks.
Jeremy.