Bug 6069 - Build breaks with too many arguments to samba-3.3.0/source/smbd/dnsregister.c:85:event_add_timed()
Summary: Build breaks with too many arguments to samba-3.3.0/source/smbd/dnsregister.c...
Alias: None
Product: Samba 3.3
Classification: Unclassified
Component: File services (show other bugs)
Version: 3.3.0
Hardware: x86 Mac OS X
: P3 major
Target Milestone: ---
Assignee: Jeremy Allison
QA Contact: Samba QA Contact
Depends on:
Reported: 2009-01-27 13:42 UTC by Andrew Klosterman
Modified: 2009-02-02 04:20 UTC (History)
1 user (show)

See Also:

Patch (445 bytes, patch)
2009-01-27 16:58 UTC, Jeremy Allison
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Klosterman 2009-01-27 13:42:29 UTC
I have had a build break with "too many arguments" errors in samba-3.3.0/source/smbd/dnsregister.c, line 85, for an invocation of a macro "event_add_timed()".

Taking/commenting out the character string argument of "DNS registration handler" allows the compile to proceed.

A grep through the source code found all other invocations of "event_add_timed()" with the correct 5 arguments.

The problem manifest itself when building on Mac OS X.

I run into no trouble building on Linux or FreeBSD (that's strange, the extra argument is still present).

$ gcc --version
i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5490)

Compiling smbd/dnsregister.c
smbd/dnsregister.c:90:13: error: macro "event_add_timed" passed 6 arguments, but takes just 5
smbd/dnsregister.c: In function 'schedule_dns_register_smbd_retry':
smbd/dnsregister.c:85: error: 'event_add_timed' undeclared (first use in this function)
smbd/dnsregister.c:85: error: (Each undeclared identifier is reported only once
smbd/dnsregister.c:85: error: for each function it appears in.)
The following command failed:
gcc -I. -I/Users/akloster/src/samba/samba-3.3.0/source  -O -D_SAMBA_BUILD_=3 -fno-common -I/Users/akloster/src/samba/samba-3.3.0/source/popt -I/Users/akloster/src/samba/samba-3.3.0/source/iniparser/src -Iinclude -I./include  -I. -I. -I./lib/replace -I./lib/talloc -I./lib/tdb/include -I./libaddns -I./librpc -DHAVE_CONFIG_H  -Iinclude -I./include -I. -I. -I./lib/replace -I./lib/talloc -I./lib/tdb/include -I./libaddns -I./librpc -I./popt -DLDAP_DEPRECATED   -I/include -I/Users/akloster/src/samba/samba-3.3.0/source/lib -D_SAMBA_BUILD_=3 -fPIE -c smbd/dnsregister.c -o smbd/dnsregister.o
make: *** [smbd/dnsregister.o] Error 1
Comment 1 Jeremy Allison 2009-01-27 16:58:00 UTC
Created attachment 3894 [details]

This got missed in the events conversion. The attached patch should fix this.
Comment 2 Karolin Seeger 2009-02-02 04:20:03 UTC
Closing out bug report.

Please re-open if the patch does not solve the problem.

Thanks for reporting!