Bug 6066 - 3.2 can't compile netinet/ip.h on Solaris any more
3.2 can't compile netinet/ip.h on Solaris any more
Status: RESOLVED FIXED
Product: Samba 3.2
Classification: Unclassified
Component: Build environment
3.2.1
Sparc Solaris
: P3 normal
: ---
Assigned To: Michael Adam
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-26 10:43 UTC by David S. Collier-Brown
Modified: 2009-01-27 10:19 UTC (History)
1 user (show)

See Also:


Attachments
patch (1.20 KB, patch)
2009-01-27 05:46 UTC, Michael Adam
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David S. Collier-Brown 2009-01-26 10:43:56 UTC
Suresh Khatry wrote:
>  Getting following warning when compiling 3.2.7 on Solaris 9 Sparc box.  Using gcc 3.3

as did 

Erik Moyer <ejmoyer@gmail.com> on Solaris 10.

> configure: WARNING: netinet/ip.h: present but cannot be compiled
> configure: WARNING: netinet/ip.h:     check for missing prerequisite headers?
> configure: WARNING: netinet/ip.h: see the Autoconf documentation
> configure: WARNING: netinet/ip.h:     section "Present But Cannot Be Compiled"
> configure: WARNING: netinet/ip.h: proceeding with the preprocessor's  result
> configure: WARNING: netinet/ip.h: in the future, the compiler will take precedence
> configure: WARNING:     ## Report this to samba-technical@samba.org ##
Comment 1 Michael Adam 2009-01-27 05:02:15 UTC
just testing a fix...
Comment 2 Michael Adam 2009-01-27 05:46:04 UTC
Created attachment 3892 [details]
patch

Attached patch should fix the issue. Pleas verify as follows:

* apply the patch to 3.2.7 sources or to a checkout of v3-2-test
* cd samba-3.2.7/source (e.g.)
* run ./autogen.sh
* rm -f config.cache
* ./configure
* see config.log or output of configure

I have pushed the patch (or an adapted version) to all branches:
master, v3-3-test, v3-2-test, v3-0-test

Cheers - Michael
Comment 3 Michael Adam 2009-01-27 08:44:03 UTC
I have verified the patch on Solaris 10.

The build farm likes it, too:
http://build.samba.org/?function=View+Build;host=sunX;tree=samba_3_X_test;compiler=gcc

The Solaris 8 build is fine, too:
http://build.samba.org/?function=View+Build;host=SerNet-solaris8;tree=samba_3_X_test;compiler=gcc

But I noticed that the configure check for netinet/ip.h fails here because
some definitions from <netinet/in_systm.h> are missing.
I just tested another fix that settles this issue,
will push to all branches.

I am going to close this bug once that next commit has hit the build farm.
Comment 4 Michael Adam 2009-01-27 10:19:11 UTC
ok, the patch in devel has reached our Solaris 8 machine in the build farm:
http://build.samba.org/?function=View+Build;host=SerNet-solaris8;tree=samba_3_X_devel;compiler=cc

I am closing this bug.
Please re-open when you do have any problems still.

Cheers - Michael