Bug 6065 - libsmbclient-3.2 is not reentrant
Summary: libsmbclient-3.2 is not reentrant
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.2
Classification: Unclassified
Component: libsmbclient (show other bugs)
Version: 3.2.7
Hardware: Other Linux
: P3 normal
Target Milestone: ---
Assignee: Derrell Lipman
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-26 10:33 UTC by Miklos Szeredi
Modified: 2009-05-14 09:54 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miklos Szeredi 2009-01-26 10:33:29 UTC 
libsmbclient-3.2 is not reentrant, while libsmbclient-3.0 is.  This causes fusesmb to crash, which assumes reentrancy.  See

  https://bugzilla.novell.com/show_bug.cgi?id=467184

This is caused by the introduction of talloc_stack.c which uses global variables to build up a stack of allocations.

I've worked around this in fusesmb by disabling multi threading, I don't know if it's feasible or not to fix this in samba3, but this definitely should not be forgotten in the long run.
Comment 1 Jeremy Allison 2009-01-26 11:26:14 UTC 
The goal eventually is to make libsmbclient thread safe, so we are on the same page on this.
Jeremy.
Comment 2 Derrell Lipman 2009-05-14 09:54:41 UTC 
This is the first of the thread-safety issues to have been fixed in the 'master' branch. Much more thread-safety work to be done, but this bug can be closed now.

Derrell