Bug 6008 - add/change share command sometimes take 4 (not 5) parameters
Summary: add/change share command sometimes take 4 (not 5) parameters
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.2
Classification: Unclassified
Component: Docs (show other bugs)
Version: 3.2.6
Hardware: x86 All
: P3 trivial
Target Milestone: ---
Assignee: Samba Bugzilla Account
QA Contact: Samba Documentation QA Contact~
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-02 10:08 UTC by TAKAHASHI Motonobu
Modified: 2009-01-06 05:31 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description TAKAHASHI Motonobu 2009-01-02 10:08:35 UTC 
(1) add share command/delete share command

There is a description that:

-----
           If the connected account has SeDiskOperatorPrivilege, scripts
           defined in **change** share parameter are executed as root.
-----

The word "change" should be "add" or "delete".

(2) add/change share command

There is a description that:

-----
           When executed, smbd will automatically invoke the add/change share command
           with five parameters.
-----

But when this parameter is called via RAP, such as "net rap share add" command, 
source/smbd/lanman.c:api_RNetShareAdd() is called with 4 parameters.
Comment 1 TAKAHASHI Motonobu 2009-01-02 11:59:31 UTC 
[Memo]
Original add/change share command take 4 parameters.
At Samba 3.0.21b, 'max connections' support was added.

http://us6.samba.org/samba/history/samba-3.0.21b.html

    * Hook the max connections spin box in the share properties 
      MMC plug-in dialog to the 'max connections' smb.conf parameter
      and the 'modify share command' option.
Comment 2 Karolin Seeger 2009-01-06 05:31:14 UTC 
Fixed with commit 8b7f66c5 in master.
Will be included in the next releases.

Thanks for reporting!