Bug 6000 - Bashism in examples/perfcountd/perfcountd.init
Bashism in examples/perfcountd/perfcountd.init
Status: RESOLVED FIXED
Product: Samba 3.3
Classification: Unclassified
Component: Docs
3.3.0rc2
Other Linux
: P3 minor
: ---
Assigned To: Samba Bugzilla Account
Samba Documentation QA Contact~
http://bugs.debian.org/489656
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-29 04:09 UTC by Debian samba package maintainers (PUBLIC MAILING LIST)
Modified: 2009-01-05 08:01 UTC (History)
0 users

See Also:


Attachments
Proposed patch (312 bytes, patch)
2008-12-29 04:10 UTC, Debian samba package maintainers (PUBLIC MAILING LIST)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Debian samba package maintainers (PUBLIC MAILING LIST) 2008-12-29 04:09:30 UTC
While that script claims to be a /bin/sh script it contains a bashism:
root@mykerinos:/usr/share/doc/samba-doc/examples/perfcounter> checkbashisms perfcountd.init
possible bashism in perfcountd.init line 50 (should be 'b = a'):
        if [ "$pid" == "" ]; then

Even though my shell skills are limited I can propose using "-z"...See attached patch
Comment 1 Debian samba package maintainers (PUBLIC MAILING LIST) 2008-12-29 04:10:08 UTC
Created attachment 3834 [details]
Proposed patch

Proposed patch
Comment 2 Karolin Seeger 2009-01-05 08:01:10 UTC
Fixed in all branches with 73875cd3 (master) and friends.

Thanks for the patch!