Bug 5969 - smbclient x_fread optimization
Summary: smbclient x_fread optimization
Alias: None
Product: Samba 3.2
Classification: Unclassified
Component: Client tools (show other bugs)
Version: 3.2.6
Hardware: Other Linux
: P3 enhancement
Target Milestone: ---
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
Depends on:
Reported: 2008-12-14 14:12 UTC by Andrew Gaul
Modified: 2008-12-15 05:56 UTC (History)
0 users

See Also:

optimize smbclient write performance (724 bytes, patch)
2008-12-14 14:13 UTC, Andrew Gaul
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gaul 2008-12-14 14:12:06 UTC
smbclient calls x_fread which in turn does calls x_getc, copying each byte one at a time.  This limits write performance, even on a fast Opteron 2.4 GHz.  The forthcoming patch accelerates writing to a NetApp FAS 2020 from 36 MB/s with 25% CPU usage to 44 MB/s with 8% CPU usage.  Applies cleanly against 3.2.6 and 3.3.0rc1.
Comment 1 Andrew Gaul 2008-12-14 14:13:43 UTC
Created attachment 3812 [details]
optimize smbclient write performance
Comment 2 Volker Lendecke 2008-12-14 16:00:56 UTC
Sometimes it's really funny... Right now I'm optimizing smbclient put as well, but more on the network side. Thanks for your patch, I'll look at it v soon!

Comment 3 Volker Lendecke 2008-12-15 05:56:36 UTC
Pushed a slightly different patch to v3-3-test and v3-2-test. I had already fixed this in the master branch, and for clarity I used that slightly different patch. Also, your patch would not compile on standard C compilers, it contains a variable declaration inside a statement block.

Can you check if http://git.samba.org/?p=samba.git;a=commitdiff;h=e504256f849 also fixes your problem?

Thanks for pinging me :-)