Bug 5956 - vfs_extd_audit logging fix.
vfs_extd_audit logging fix.
Status: RESOLVED FIXED
Product: Samba 3.2
Classification: Unclassified
Component: VFS Modules
3.2.5
x86 Linux
: P3 minor
: ---
Assigned To: Samba Bugzilla Account
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-09 08:37 UTC by Oskar Wycislak
Modified: 2009-01-21 11:34 UTC (History)
1 user (show)

See Also:


Attachments
vfs_extd_audit.c patch (7.41 KB, patch)
2008-12-09 08:40 UTC, Oskar Wycislak
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oskar Wycislak 2008-12-09 08:37:33 UTC
Hello there Samba developers!

In short:
Problem is that this module don't parse smb.conf parameters correctly.
If I set syslog = 0 in smb.conf it's still logging to syslog.
Second thing is if I set VFS logging level (log level = 0 vfs:3) it doesn't work (module still use global log level).
According to samba documentation at http://us3.samba.org/samba/docs/man/Samba-HOWTO-Collection/VFS.html#id2617119 it should work.

I have found partial fix at https://bugzilla.samba.org/show_bug.cgi?id=3518 provided by Oliver Schulze but it's adding new parameter instead of parsing right one.

I wrote a simple patch to fix this, please see the attachment.
Comment 1 Oskar Wycislak 2008-12-09 08:40:05 UTC
Created attachment 3796 [details]
vfs_extd_audit.c patch

A patch.
Comment 2 Lars Müller 2009-01-21 10:22:38 UTC
We've reviewed your patch and consider your first hunk as wrong.

If we #define DBGC_CLASS as DBGC_VFS the DEBUG() statements never use the value of vfs_extd_audit_debug_level.
Comment 3 Karolin Seeger 2009-01-21 11:34:35 UTC
Modified patch applied to master with commit 3089cfcc.
Closing out bug report.

Thanks for reporting and providing the patch!