Here is a small patch to prevent an out of memory error when a idmap backend has no parameters on a DC: --- samba-3.2.4/source/winbindd/idmap.c.rmap 2008-11-29 11:06:49.000000000 +0100 +++ samba-3.2.4/source/winbindd/idmap.c 2008-11-29 11:07:31.000000000 +0100 @@ -555,8 +555,12 @@ * set the destructor for this domain */ talloc_set_destructor(dom, close_domain_destructor); - dom->params = talloc_strdup(dom, compat_params); - IDMAP_CHECK_ALLOC(dom->params); + if (compat_params) { + dom->params = talloc_strdup(dom, compat_params); + IDMAP_CHECK_ALLOC(dom->params); + } else { + dom->params = NULL; + } /* Finally instance a backend copy for this domain */ ret = dom->methods->init(dom);
Karolin, this is apparently the no memory error we had seen lately.
Okay, this patch indeed fixes the out of memory message on my box, too. How to reproduce without the patch: -editposix setup -net sam provision does not work with the following Winbind config: idmap uid = 10000-20000 idmap gid = 10000-20000 idmap backend = tdb idmap config DOM:backend = tdb idmap config DOM:range = 21000-30000 Can provide a log and the full smb.conf if needed.
Simo, sorry, Günther just acked the patch. Maybe you like to review it nonetheless. Pushed to v3-2-test. Will be included in 3.2.12. Closing out bug report. Thanks for reporting and providing the patch!
No problems its evident it is good.