Bug 5929 - vfs_prealloc does not build with option --with-cluster-support and GPFS
Summary: vfs_prealloc does not build with option --with-cluster-support and GPFS
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.2
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 3.2.4
Hardware: All Linux
: P3 normal
Target Milestone: ---
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-01 03:07 UTC by Henning Henkel
Modified: 2008-12-04 15:45 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henning Henkel 2008-12-01 03:07:15 UTC 
Tried building the Sernet-Source-RPM for 3.2.4 with the option "--with-cluster-support" and got an error building when GPFS is installed on the system. As it is not a problem with the sernet package, but more a generell samba bug, I propose the attached patch which also applies for Samba 3.2.5, as it is obvious that "int err" is defined at the wrong place.

Cheers

Henning 

-- samba-3.2.4/source/modules/vfs_prealloc.c.orig	2008-11-28 15:05:24.000000000 +0100
+++ samba-3.2.4/source/modules/vfs_prealloc.c	2008-11-28 15:05:52.000000000 +0100
@@ -56,9 +56,9 @@
 
 static int preallocate_space(int fd, SMB_OFF_T size)
 {
+	int err;
 #ifndef HAVE_GPFS
 	lock_type fl = {0};
-	int err;
 
 	if (size <= 0) {
 		return 0;
Comment 1 Jeremy Allison 2008-12-04 15:45:05 UTC 
Applied, thanks !
Jeremy.