Bug 5889 - "delete veto files = no" seems to break
Summary: "delete veto files = no" seems to break
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.2
Classification: Unclassified
Component: File services (show other bugs)
Version: 3.2.4
Hardware: x86 Windows XP
: P3 minor
Target Milestone: ---
Assignee: Jeremy Allison
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-11 09:13 UTC by TAKAHASHI Motonobu
Modified: 2008-11-12 17:50 UTC (History)
0 users

See Also:

Attachments
Patch for 3.2.x. (974 bytes, patch)
2008-11-11 16:20 UTC, Jeremy Allison 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description TAKAHASHI Motonobu 2008-11-11 09:13:07 UTC 
"delete veto files = no" seems to break.

(1) Created
  dir1 (rwxrwxrwx)
    |
    |
    +-- invisible (rwxrwxrwx)

(2) set in smb.conf:

-----
  veto files = /invisible/
  delete veto files = no (default)
-----

  Directory "invisible" can not access from Windows because of "veto files" parameter (This is OK).

(3) rmdir /s /q dir1 on Windows 

(4) Expected behavior is that deleting dir1 is failed but actually not.

I checked this at Samba 3.2.4/Samba 3.0.24/Samba 2.2.12.
Comment 1 Jeremy Allison 2008-11-11 16:20:15 UTC 
Created attachment 3725 [details]
Patch for 3.2.x.

This fixes it for 3.2.x and above. The problem was were were only looking at this parameter for a directory, not a file. Thanks for the bug report.
Jeremy.
Comment 2 Jeremy Allison 2008-11-11 16:21:59 UTC 
Fixed in all git trees.
Jeremy.
Comment 3 TAKAHASHI Motonobu 2008-11-12 17:50:54 UTC 
I applied this patch and found this bug was fixed. Thanks!