I have tested smbcontrol in Samba 3.0 on my Linux box and faced with a problem. Referring to smbcontrol usage, it states that the <destination> parameter can be either one of "smbd", "nmbd" or actual PID. While specifying PID as <destination> within the command- line would close down the client connetion as intended, however, specifying "smbd" does not have any effect on the connection. e.g. $ smbcontrol PID close-share SHARE works $ smbcontrol smbd close-share SHARE doesn't work Is this a bug, or just a feature of this tool? Cheers
Created attachment 831 [details] Allow to call smbcontrol with the daemon name First hunk: Return from traverse_fn() if crec.cnum is -1. Am I correct that this isn't a connection so we return without doing anything? Second hunk: Set in make_connection_snum() the flags of this connection with claim_connection() to FLAG_MSG_GENERAL|FLAG_MSG_SMBD I'm not sure if we need FLAG_MSG_GENERAL here. At least we need FLAG_MSG_SMBD to be set to allow traverse_fn() to work. Please advice.
This patch is wrong. Sorry for the noise. Just discussed with Jerry about this. This should now be fixed with the current svn version. I'll check this and if it the bug is fixed mark this a fixed/ verified.
Fixed with svn checkin 4018.