message "ERROR: string overflow by 1 (13 - 12) in safe_strcpy" keeps coming up. The client is Windows XP Professionl SP2 (32 bit), 5.01.2600. The bug depends on "mangeld names = no". I followed it: smbd/trans2.c:call_trans2findfirst() name_to_8_3(mask, mangled_name, True, conn->params); smbd/mangle.c:name_to_8_3() if (!lp_manglednames(p)) { safe_strcpy(out,in,12); In this case "mask" contains a long filename, so "in" is greater than 12.
Created attachment 3699 [details] level 10 smbd.log
Created attachment 3700 [details] tcpdump for the bug
This came in with revision 25009. Comment was: Large patch discussed with Volker. Move unix_convert to a talloc-based interface. More development will come on top of this. Remove the "mangled map" parameter. Jeremy. http://viewcvs.samba.org/cgi-bin/viewcvs.cgi/branches/SAMBA_3_2/source/smbd/mangle.c?rev=25009&r1=23866&r2=25009
Looking at that piece of code tells me that the error message is annoying but no real functional problem. Is that right? Volker
Indeed, no errors popped up so far. But: "no real functional problem" is kind of an elastic term. :-) 5 users browsing through some directories gives you literally hundreds of log entries per second. Can't put that into production.
Created attachment 3705 [details] proposed patch Can you try the attached patch? Thanks, Volker
And gone the problem is. Thx!
Pushed upstream. Thanks for the feedback, Volker
Thanks for taking care of it Volker, that change would have been my suggestion too :-).