Bug 5837 - segfault when adding a printer driver
Summary: segfault when adding a printer driver
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.2
Classification: Unclassified
Component: Printing (show other bugs)
Version: 3.2.4
Hardware: Other Linux
: P3 normal
Target Milestone: ---
Assignee: Gerald (Jerry) Carter (dead mail address)
QA Contact: Samba QA Contact
URL: http://bugs.debian.org/431696
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-19 11:22 UTC by Debian samba package maintainers (PUBLIC MAILING LIST)
Modified: 2008-11-02 03:48 UTC (History)
0 users

See Also:

Attachments
Patch proposed by Jelmer Vernooij (459 bytes, patch)
2008-10-19 11:24 UTC, Debian samba package maintainers (PUBLIC MAILING LIST) 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Debian samba package maintainers (PUBLIC MAILING LIST) 2008-10-19 11:22:52 UTC 
The whole bug story is avail. at http://bugs.debian.org/431696.

Basically, a segfault happened to our user when he tried to update a driver from a Windows client.

In the bug log, Jelmer Vernooij finally made the following analysis:

"We were freeing the files structure for the old file twice when opening the new file
failed."

He provided a patch that doesn't seem to be applied in 3.2.4 yet. I'll attach it here.
Comment 1 Debian samba package maintainers (PUBLIC MAILING LIST) 2008-10-19 11:24:50 UTC 
Created attachment 3684 [details]
Patch proposed by Jelmer Vernooij
Comment 2 Jeremy Allison 2008-10-19 20:10:17 UTC 
This has already been added into the samba-3-2-test and samba-3-2-stable git branches, as well as master and 3.3.
Should be fixed in the next release.
Thanks,
Jeremy.
Comment 3 Volker Lendecke 2008-11-02 03:48:23 UTC 
Closing the bug according to Jeremy's comment. Please re-open if it's not fixed in 3.2.5 or 3.3.

Volker