Bug 5802 - misleading error message in atomic rsync
misleading error message in atomic rsync
Product: rsync
Classification: Unclassified
Component: core
All Linux
: P3 trivial
: ---
Assigned To: Wayne Davison
Rsync QA Contact
Depends on:
  Show dependency treegraph
Reported: 2008-09-29 17:35 UTC by Eric Wong
Modified: 2008-10-03 00:33 UTC (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Eric Wong 2008-09-29 17:35:01 UTC
When renaming $dest_dir to $old_dir, don't say we're renaming
$new_dir to $old_dir on errors.

--- a/atomic-rsync
+++ b/atomic-rsync
@@ -48,7 +48,7 @@ if (system($RSYNC_PROG, "--link-dest=$dest_dir", @ARGV)) {
     exit $?;
-rename($dest_dir, $old_dir) or die "Unable to rename $new_dir to $old_dir: $!";
+rename($dest_dir, $old_dir) or die "Unable to rename $dest_dir to $old_dir: $!"
 rename($new_dir, $dest_dir) or die "Unable to rename $new_dir to $dest_dir: $!"
Comment 1 Wayne Davison 2008-10-02 13:54:25 UTC
I fixed this in the git repository.
Comment 2 Matt McCutchen 2008-10-02 19:49:30 UTC
I do not see the fix in the git repository at http://gitweb.samba.org/?p=rsync.git;a=summary .
Comment 3 Wayne Davison 2008-10-03 00:33:21 UTC