Bug 5800 - please provide "tdbtool check" subcommand
please provide "tdbtool check" subcommand
Status: RESOLVED FIXED
Product: Samba 3.3
Classification: Unclassified
Component: Client tools
unspecified
Other Linux
: P3 normal
: ---
Assigned To: Samba Bugzilla Account
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-29 10:09 UTC by Jelmer Vernooij
Modified: 2008-12-16 07:05 UTC (History)
2 users (show)

See Also:


Attachments
patch to add a "check" command to tdbtool (2.23 KB, patch)
2008-11-01 17:38 UTC, Holger Hetterich
no flags Details
reviewed patch (2.24 KB, patch)
2008-11-01 17:46 UTC, Holger Hetterich
no flags Details
reviewed patch (2.25 KB, patch)
2008-11-01 18:15 UTC, Holger Hetterich
no flags Details
patch to add the "check" command to the tdbtool manpage (853 bytes, patch)
2008-11-20 03:35 UTC, Holger Hetterich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jelmer Vernooij 2008-09-29 10:09:35 UTC
It would be useful if tdbtool provided a simple subcommand for checking the integrity of a tdb file.
Comment 1 Holger Hetterich 2008-11-01 17:38:14 UTC
Created attachment 3702 [details]
patch to add a "check" command to tdbtool

This runs traverse on the currently open tdb file and prints the number of entries if the integrity check is succesful.
Comment 2 Holger Hetterich 2008-11-01 17:46:29 UTC
Created attachment 3703 [details]
reviewed patch

reviewed. Now really print out the number of entries in the tdb.
Comment 3 Holger Hetterich 2008-11-01 18:15:56 UTC
Created attachment 3704 [details]
reviewed patch

reviewed another time :)

This time really check the database given in the arguments for the function.
Comment 4 Holger Hetterich 2008-11-20 03:35:13 UTC
Created attachment 3755 [details]
patch to add the "check" command to the tdbtool manpage

This adds documentation for the check command to the tdbtool manpage
Comment 5 Karolin Seeger 2008-12-16 07:05:20 UTC
Both patches are now upstream (master and v3-3-test).
Will be in 3.3.0.
Closing out bug report.

Thanks for the patches! :-)