Bug 5732 - xattrs.test calls wrong rsync
Summary: xattrs.test calls wrong rsync
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.0.4
Hardware: All Linux
: P3 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
Depends on:
Reported: 2008-09-03 09:35 UTC by Petr Uzel
Modified: 2008-09-03 18:02 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Petr Uzel 2008-09-03 09:35:17 UTC
In rsync 3.0.4pre2, the xattrs.test at some places does not call rsync as $RSYNC, but simply as rsync, which causes that :
1) the test fails on systems where rsync is not installed
2) it tests wrong binary (/usr/bin/rsync)

Following patch fixes the problem:

From 844bdb5d32afe8ea7e59d0ea0c5dc9ce688c69d7 Mon Sep 17 00:00:00 2001
From: Petr Uzel <petr.uzel@suse.cz>
Date: Wed, 3 Sep 2008 16:12:31 +0200
Subject: [PATCH] Fix xattrs.test - use $RSYNC instead of plain rsync

 testsuite/xattrs.test |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/testsuite/xattrs.test b/testsuite/xattrs.test
index 86758fa..8b40eec 100644
--- a/testsuite/xattrs.test
+++ b/testsuite/xattrs.test
@@ -116,10 +116,10 @@ fi
 cd "$fromdir"
 rm -rf "$todir" "$chkdir"

-rsync -aX file1 file2
-rsync -aX file1 file2 ../chk/
-rsync -aX --del ../chk/ .
-rsync -aX file1 ../lnk/
+$RSYNC -aX file1 file2
+$RSYNC -aX file1 file2 ../chk/
+$RSYNC -aX --del ../chk/ .
+$RSYNC -aX file1 ../lnk/

 xls file1 file2 >"$scratchdir/xattrs.txt"

@@ -132,7 +132,7 @@ cd "$fromdir"
 rm "$todir/file2"

 echo extra >file1
-rsync -aX . ../chk/
+$RSYNC -aX . ../chk/

 checkit "$RSYNC -aiiX . ../to" "$chkdir" "$todir"

Comment 1 Wayne Davison 2008-09-03 18:02:19 UTC
Thanks for pointing that out.  I checked in your fix earlier today.