Bug 562 - change notify bug?
change notify bug?
Status: RESOLVED FIXED
Product: Samba 2.2
Classification: Unclassified
Component: File Services
2.2.8a
All All
: P5 minor
: ---
Assigned To: Jeremy Allison
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2003-10-04 03:22 UTC by YAMASAKI Hiroyuki
Modified: 2003-10-06 14:49 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description YAMASAKI Hiroyuki 2003-10-04 03:22:45 UTC
Sorry for my poor english.
In samba source smbd/notify_hash.c notify_hash function, comment says "sum 
mode_t".  But not calculate sum. Is this a bug?

    data->mode_sum = st.st_mode;
                   v typo? 
    data->mode_sum += st.st_mode;
                   

-----------------------------------------------
while ((fname = ReadDirName(dp))) {
   (snip)
  /*
   * If requested sum the mode_t's.
   */

  if (flags & (FILE_NOTIFY_CHANGE_ATTRIBUTES|FILE_NOTIFY_CHANGE_SECURITY))
    data->mode_sum = st.st_mode;         <----- this
}                  

-----------------------------------------------
Comment 1 Gerald (Jerry) Carter 2003-10-06 06:16:48 UTC
Jeremy, I this a bug?  If so, does it exist in 3.0?
Comment 2 Jeremy Allison 2003-10-06 14:49:52 UTC
Yep - good catch - stupid typo :-(. !
Applied in SAMBA_3_0 and HEAD.
Thanks,

Jeremy.