Sorry for my poor english. In samba source smbd/notify_hash.c notify_hash function, comment says "sum mode_t". But not calculate sum. Is this a bug? data->mode_sum = st.st_mode; v typo? data->mode_sum += st.st_mode; ----------------------------------------------- while ((fname = ReadDirName(dp))) { (snip) /* * If requested sum the mode_t's. */ if (flags & (FILE_NOTIFY_CHANGE_ATTRIBUTES|FILE_NOTIFY_CHANGE_SECURITY)) data->mode_sum = st.st_mode; <----- this } -----------------------------------------------
Jeremy, I this a bug? If so, does it exist in 3.0?
Yep - good catch - stupid typo :-(. ! Applied in SAMBA_3_0 and HEAD. Thanks, Jeremy.