Bug 558 - All files complain about missing ISO8859-1.so on solaris
All files complain about missing ISO8859-1.so on solaris
Status: CLOSED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: Build environment
3.0.0
All Solaris
: P3 major
: none
Assigned To: Alexander Bokovoy
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2003-10-02 15:24 UTC by Steven Tamm
Modified: 2005-11-14 09:25 UTC (History)
1 user (show)

See Also:


Attachments
Plugin Module for Latin 1 (fix solaris warnings) (1.86 KB, text/plain)
2003-10-02 15:27 UTC, Steven Tamm
no flags Details
Support ISO-8859-1 internally (1.18 KB, patch)
2003-12-08 08:02 UTC, Alexander Bokovoy
no flags Details
Support ISO-8859-1 internally (1.62 KB, patch)
2003-12-10 07:57 UTC, Alexander Bokovoy
no flags Details
Support ISO-8859-1 internally (1.62 KB, patch)
2003-12-10 07:57 UTC, Alexander Bokovoy
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steven Tamm 2003-10-02 15:24:02 UTC
The default locale for users on Solaris 8 is ISO8859-1, and as such it appears
that all functions complain with the following error.

[2003/10/02 10:47:56, 0] lib/module.c:(58)
  Error trying to resolve symbol 'init_module' in
/usr/local/samba/lib/charset/CP850.so: ld.so.1: /usr/local/samba/sbin/nmbd:
fatal: /usr/local/samba/lib/charset/ISO8859-1.so: open failed: No such file or
directory
[2003/10/02 10:47:56, 0] lib/charcnv.c:(134)
  Conversion from UCS-2LE to CP850 not supported

There needs to be a codepage plugin for ISO8859-1 to be installed on solaris. 
This is probably a specific instance of a more global problem.  

I created an ISO8859_1.c file that generates a the trivial converters for
ISO8859-1.
Comment 1 Steven Tamm 2003-10-02 15:27:02 UTC
Created attachment 177 [details]
Plugin Module for Latin 1 (fix solaris warnings)

There are a few of tweaks I made to the Makefile, mostly copying whatever it
was doing for CP850.so and doing it for ISO8859-1.so.  And you have to modify
config.h  to have the following mapping. 

/* Place this in the config.h parameters */
#define charset_latin1_init init_module

I wrote this just to get by; it was easy because latin1 (ISO8859-1) is a
trivial case.
Comment 2 Tim Potter 2003-10-02 17:40:54 UTC
Reassigning to ab - the modules guy.
Comment 3 Gerald (Jerry) Carter 2003-12-07 22:45:23 UTC
ab, i know tridge changed some details post 3.0.0.  Please either 
accept the patch included here, reject it (and give a reason) and 
close the report.  Thanks.
Comment 4 Alexander Bokovoy 2003-12-08 02:40:48 UTC
Patch looks good. However, I wonder if we better would implement it directly in
lib/iconv.c -- as we already have part of it (pull function) as ascii_pull
there. Only push function for ascii is different -- it removes 8th bit. So I'll
put it into lib/iconv.c and share implementation between it and ascii charset.
Comment 5 Alexander Bokovoy 2003-12-08 08:02:27 UTC
Created attachment 306 [details]
Support ISO-8859-1 internally

I'm attaching new proposed patch for the fix. Please check if it would work for
you.
Comment 6 Alexander Bokovoy 2003-12-10 07:57:26 UTC
Created attachment 313 [details]
Support ISO-8859-1 internally

This is revised version which actually works
Comment 7 Alexander Bokovoy 2003-12-10 07:57:36 UTC
Created attachment 315 [details]
Support ISO-8859-1 internally

This is revised version which actually works
Comment 8 Alexander Bokovoy 2003-12-10 08:02:10 UTC
Commited to CVS, should be in 3.0.1RC2.
Comment 9 Gerald (Jerry) Carter 2005-08-24 10:21:43 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.
Comment 10 Gerald (Jerry) Carter 2005-11-14 09:25:08 UTC
database cleanup