The Samba-Bugzilla – Bug 5558
-- Stats Output
Last modified: 2008-07-26 10:49:58 UTC
When using a multi line batch file to synch two systems the --stats output gives no indication of which line in the batch file the individual stats refer to
It would be helpful and make the output easier to understand if the stats output printed the rsync command executed as the first line of any stats
To place the above suggestion into context, I synchronise 8 directories on two machines daily using cron/rsync with the stats emailed to two administrators.
The stats are great and assist in identifying problems but it is a pain remembering which group of stats belong to which directory.
If it is considered a security problem having the full rsync command as the first line of the stats output perhaps the source or destination section of the command line could be utilised
You can print the rsync command yourself using an "echo" in the batch file.
Yes I can use an echo, but surely we are all looking to improve the product and in this case readability of the --stats output
The current output is like having an answer to a question without the question
(In reply to comment #2)
> Yes I can use an echo, but surely we are all looking to improve the product and
> in this case readability of the --stats output
We are not looking to bloat rsync with features easily implemented outside of it. Besides, the command is not a statistic. You're welcome to use a modified version of rsync that prints the command with --stats if you wish.
With all due respect, a small improvement in readability surely could not be considered bloat, more like commonsense, and to suggest that --stats does not provide statistics is a surprising statement to say the least.
Perhaps this could be linked to the other change (bud 2602) to improve stats which is more complex & has been outstanding since 2005
I would also like to see some information on files/directories added/deleted
I agree with Matt that this is not something that --stats should output. The person calling rsync is in a much better position to know how best to summarize what the copy is doing (e.g. echo the whole command, echo the destination, etc.) than rsync would be. Matt also meant that it is this extra output that you are requesting that is not a statistic, not the --stats option.
I have made the suggestion and it has been rejected
I will however continue to regard the need to add a comment explaining the meaning of the statistics externally to rsync as a work around rather than a solution
At the same time could I thank all who have made rsync such a great powerful tool
their efforts are certainly appreciated