Bug 5401 - getpassf() should honor strict modes
Summary: getpassf() should honor strict modes
Status: ASSIGNED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.0.3
Hardware: All OS/2
: P3 enhancement (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-17 12:33 UTC by Steven H. Levine
Modified: 2008-06-11 12:29 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steven H. Levine 2008-04-17 12:33:27 UTC 
Porting to platforms without true stat() support would be simpler if getpassf() (authentic.c) honored the strict modes option.  The code would be similar to the existing code in get_secret().
Comment 1 Wayne Davison 2008-04-17 12:48:04 UTC 
The strict-modes setting is a daemon setting.  The getpassf() function is a client function, so the two are not related.

It might be nice to have a way to make the client strict -- perhaps a configure option.
Comment 2 Steven H. Levine 2008-04-17 13:12:15 UTC 
Oops, I forgot to consider that this was a client side issue.

A configure option would be handy.  For now, we will just patch it out with an #ifdef.

In case you would like to add the OS/2 port to your list of available binaries, it can be found at

  http://www.smedley.info/os2ports/index.php?page=rsync
Comment 3 Steven H. Levine 2008-06-11 12:29:09 UTC 
This was reported to the rsync team as

https://bugzilla.samba.org/show_bug.cgi?id=5401

As was pointed out by the maintainers, I goofed on my suggested fix.  What's really needed is to #ifdef the code based on a configure variable.  If might be sufficient to just use __OS2__.