Bug 5310 - vfs_notify_fam module are not compiled
Summary: vfs_notify_fam module are not compiled
Status: RESOLVED WORKSFORME
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.0.28
Hardware: x86 Linux
: P3 normal
Target Milestone: none
Assignee: Simo Sorce
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-06 07:40 UTC by Ricardo Santos
Modified: 2009-02-19 09:23 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ricardo Santos 2008-03-06 07:40:42 UTC 
Compiling 3.0.28 on Fedora 8 with --enable-fam option, vfs_notify_fam module wasn't compiled. I have fam lib installed:

configure:44069: checking for FAMOpen2 in -lfam
configure:44128: result: yes

I guess is missed this code on configure file:

        echo "$as_me:$LINENO: checking how to build vfs_notify_fam" >&5
echo $ECHO_N "checking how to build vfs_notify_fam... $ECHO_C" >&6
        if test "$MODULE_vfs_notify_fam"; then
                DEST=$MODULE_vfs_notify_fam
        elif test "$MODULE_vfs" -a "$MODULE_DEFAULT_vfs_notify_fam"; then
                DEST=$MODULE_vfs
        else
                DEST=$MODULE_DEFAULT_vfs_notify_fam
        fi

This code above was included on 3.2.0pre2

Ricardo Santos
Comment 1 Volker Lendecke 2008-03-08 03:28:45 UTC 
Assigning to idra. The configure.in snippets regarding notify_fam are absolutely equivalent in v3-0-test and v3-2-test, and I don't have fc8 around to test this.

Volker
Comment 2 Björn Jacke 2009-02-19 09:23:12 UTC 
it works on SuSE and BSD, I can't tell about Red Hat. But Linux should not require fam support anyway as inotify is superior and available since a while. I'm closing this bug as it seems to be generic problem with Samba and FAM.