Bug 5171 - perl syntax error in genlogon.pl
perl syntax error in genlogon.pl
Status: RESOLVED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: File Services
3.0.28
All All
: P3 trivial
: none
Assigned To: Samba Bugzilla Account
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-04 01:26 UTC by Jason Filley
Modified: 2008-01-14 08:49 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Filley 2008-01-04 01:26:22 UTC
# pwd
/usr/local/src/samba-3.0.28

# find . -name \*.pl -exec perl -c '{}' \;
...
syntax error at ./examples/logon/genlogon/genlogon.pl line 49, near ")
{"
syntax error at ./examples/logon/genlogon/genlogon.pl line 52, near "}"
./examples/logon/genlogon/genlogon.pl had compilation errors.
...

# diff -u genlogon.pl.orig genlogon.pl
--- genlogon.pl.orig    Wed Jan  2 17:47:49 2008
+++ genlogon.pl Wed Jan  2 17:48:01 2008
@@ -45,7 +45,7 @@
 }

 # Connect shares just used by Administration staff
-If ($ARGV[1] eq "ADMIN" || $ARGV[0] eq "admin")
+if ($ARGV[1] eq "ADMIN" || $ARGV[0] eq "admin")
 {
        print LOGON "NET USE L: \\\\$ARGV[2]\\ADMIN\r\n";
        print LOGON "NET USE K: \\\\$ARGV[2]\\MKTING\r\n";
Comment 1 Michael Adam 2008-01-14 08:49:05 UTC
Hi Jason,

thanks for noting this.
I have fixed in v3-0-test (73647214ae96f1ecd244b71d35048685f8c7ea8a)
and v3-2-test (dcb5034acd35d219106e1d855f4c4d36b3c8d83b).

Michael