Bug 5110 - autoconf does not generate correct #defines for VFS examples
Summary: autoconf does not generate correct #defines for VFS examples
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: VFS (show other bugs)
Version: 3.0.27
Hardware: x86 Linux
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-27 06:55 UTC by Leonardo Bettarello
Modified: 2019-06-19 04:15 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leonardo Bettarello 2007-11-27 06:55:26 UTC 
Under examples/VFS, autoconf generates ./configure which in turn generates a wrong Makefile for the VFS examples ***WITHOUT*** the following #defines (with respect to the main Samba ./configure):

-D_SAMBA_BUILD_=3 -DHAVE_CONFIG_H -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DLDAP_DEPRECATED

This leads to structures disalignment between Samba daemon and VFS binaries, e.g.:

sizeof(SMB_STRUCT_STAT) == 96 in Samba
sizeof(SMB_STRUCT_STAT) == 88 in VFS modules

Samba version: 3.0.27a
Platform: Redhat Linux Fedora Core 7 i386 32-bit
Comment 1 Andrew Bartlett 2019-06-19 04:15:04 UTC 
The autoconf build system in examples/VFS was removed
for Samba 4.1 by
commit cbddf9e2efd856a25c6405f6893ad3a9cda1b181
Author: Andrew Bartlett <abartlet@samba.org>
Date:   Wed May 22 14:22:36 2013 +1000

    build: Remove autoconf build system from examples/VFS
    
    Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
    
    Reviewed-by: David Disseldorp <ddiss@samba.org>