Bug 5101 - libreplace merge changed handling of default print system
Summary: libreplace merge changed handling of default print system
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Printing (show other bugs)
Version: 3.0.26a
Hardware: Other Linux
: P3 normal
Target Milestone: none
Assignee: Gerald (Jerry) Carter
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-23 12:42 UTC by Steve Langasek
Modified: 2007-11-23 17:20 UTC (History)
0 users

See Also:


Attachments
patch to restore 3.0.24 print system selection (1.87 KB, patch)
2007-11-23 12:44 UTC, Steve Langasek
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Langasek 2007-11-23 12:42:09 UTC
Since 3.0.25, Samba has been defaulting to use printing=bsd as the default instead of printing=cups even when cups support is compiled in, due to what appears to be an inadvertent change in behavior introduced when merging some libreplace updates from samba4.  Perhaps this is intentional, in which case I think some documentation/explanation for the change is warranted; but it looks wrong to me and I think it should be reverted.
Comment 1 Steve Langasek 2007-11-23 12:44:10 UTC
Created attachment 2993 [details]
patch to restore 3.0.24 print system selection

the attached patch restores the pre-3.0.25 print system selection behavior, by migrating the relevant code from source/include/includes.h to source/lib/replace/system/printing.h
Comment 2 Stefan Metzmacher 2007-11-23 17:20:32 UTC
system/printing.h is useless in it's current stade as it has only samba3
specific stuff. So the fix is just not to use it and remove it

http://git.samba.org/?p=samba.git;a=commitdiff;h=0a7338ab
http://git.samba.org/?p=samba.git;a=commitdiff;h=b73a7419