Bug 4898 - Iconv call missing a "const", and fix
Summary: Iconv call missing a "const", and fix
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: File Services (show other bugs)
Version: 3.0.9
Hardware: All All
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-19 13:41 UTC by David S. Collier-Brown
Modified: 2024-06-11 04:26 UTC (History)
1 user (show)

See Also:

Attachments
Fix for an erronious cast (376 bytes, patch)
2007-08-19 13:42 UTC, David S. Collier-Brown 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David S. Collier-Brown 2007-08-19 13:41:02 UTC 
gcc says
lib/iconv.c:140: warning: passing arg 2 of `libiconv' from incompatible pointer
In fact, it's a missed "const" in the cast, to match the definition
of Gnu (and Solaris) iconv.  Patch attached, saith the janitor (;-))
Comment 1 David S. Collier-Brown 2007-08-19 13:42:03 UTC 
Created attachment 2872 [details]
Fix for an erronious cast
Comment 2 Andrew Bartlett 2024-06-11 04:10:53 UTC 
Looks like this gets probably fixed in 7d32679e9683c81aca538f0267684332a28a286f prior to your bug but which eventually made Samba 4.0 via the merge.

It needed to actually remove the const that was promised in sys_iconv().