Bug 487 - SWAT status page cannot display correctly
SWAT status page cannot display correctly
Product: Samba 3.0
Classification: Unclassified
Component: SWAT
All All
: P3 normal
: none
Assigned To: John H Terpstra
Depends on:
Blocks: 413
  Show dependency treegraph
Reported: 2003-09-22 12:25 UTC by TAKAHASHI Motonobu
Modified: 2005-08-24 10:23 UTC (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description TAKAHASHI Motonobu 2003-09-22 12:25:44 UTC
In SWAT status page

Active Shares
Share User Group PID Share User

Open Files
PID Sharing R/W Oplock PID Sharing

The 5th and 6th column's title is wrong.

Unfortunately NUM_LANG_BUFS 4 is not sufficient for web/statuspagec:395, 407:

        d_printf("<tr><th>%s</th><th>%s</th><th>%s</th><th>%s</th>\n", _
("PID"), _("Client"), _("IP address"), _("Date"));

There are 6 items in these lines. 
Simply to increase this value is a quick fix. 16 will be enough value I think.

I think this limitation should be mentioned anywhere of Development docs. 

--- lang_tdb.c.org      Tue Sep 23 03:31:22 2003
+++ lang_tdb.c  Tue Sep 23 04:12:47 2003
@@ -210,7 +210,7 @@
 const char *lang_msg_rotate(const char *msgid)
-#define NUM_LANG_BUFS 4
+#define NUM_LANG_BUFS 16
        char *msgstr;
        static pstring bufs[NUM_LANG_BUFS];
        static int next;
Comment 1 TAKAHASHI Motonobu 2003-09-22 12:28:13 UTC
Sorry, Line 395 is OK, Linue 407 and Line 416 in statuspage.c has this problem.
Comment 2 TAKAHASHI Motonobu 2003-10-13 02:55:31 UTC
Please commit this simple patch to support SWAT i18n feature correctly.

Comment 3 John H Terpstra 2003-10-18 10:47:03 UTC
Patch applied.
Comment 4 Gerald (Jerry) Carter 2005-02-07 09:05:54 UTC
originally reported against one of the 3.0.0rc[1-4] releases.
Cleaning up non-production versions.
Comment 5 Gerald (Jerry) Carter 2005-08-24 10:23:20 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.