Bug 4802 - Feature request: Better logging format
Summary: Feature request: Better logging format
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: samba4-qa@samba.org
Depends on:
Reported: 2007-07-19 10:21 UTC by David Magda
Modified: 2010-03-04 04:11 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description David Magda 2007-07-19 10:21:22 UTC
The default logging format is kind of sucky right now. The main issue is that each event is spread across two lines.

If you grep through a log file for a user ID, hostname, or share name you find it, but since the date and time are on a different line you can't co-ordinate events easily. At the very least each event should be on one line.

Since 4.x is changing so many other things, a small tweek to the logging format to help out sysadmins (and their monitoring tools) should at least be considered.
Comment 1 Matthias Dieter Wallnöfer 2007-08-27 03:11:55 UTC
Andrew, do you think we should try to work on that?
Comment 2 Andrew Bartlett 2007-08-27 05:10:22 UTC
This would require consensus on the mailing list first.  Most developers tend to run with 'debug timestamp = no' set anyway (which is perhaps why the function name is included 'twice' so often. 
Comment 3 Matthias Dieter Wallnöfer 2007-09-01 01:28:19 UTC
We had now some propositions on the mailing list. Would we take for now the approach of Volker (http://lists.samba.org/archive/samba-technical/2007-August/055237.html)? What do you say?
Comment 4 Andrew Bartlett 2007-09-03 00:19:19 UTC
We generally want to be compatible with Samba3 on stuff like this, so if there are patches that can be ported forward, I'll be happy to review them.
Comment 5 Matthias Dieter Wallnöfer 2008-08-07 12:42:06 UTC
Is this issue concerning yet?
Comment 6 David Magda 2008-08-07 14:26:49 UTC
(In reply to comment #4)
> We generally want to be compatible with Samba3 on stuff like this, so if there
> are patches that can be ported forward, I'll be happy to review them.

Why is it necessary to be compatible with Samba3? If it's not possible to break compatibility during a major version jump, when would it be possible? At some point you need to fix architectural issues, and 3.x to 4.x is a great opportunity IMHO.

Comment 7 Matthias Dieter Wallnöfer 2010-03-04 04:11:23 UTC
I think I close this for now with "WONTFIX" since this really needs some discussion on the technical list first. Otherwise we come no further here.

I suggest you:
- Write an email to "samba-technical@samba.org" about this issue and state there your opinion about the current format (why it is bad) and give an idea how the new one should look like
- Then wait for responses from team members
- If there is interest to switch to a new format, it would be really nice if you could provide patches (I think for both s3 and s4 - since in this area, as abartlet stated, we prefer to be consistent).