Bug 4745 - Use lchmod and lutimes whenever possible
Summary: Use lchmod and lutimes whenever possible
Status: RESOLVED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.0
Hardware: Other Linux
: P3 enhancement (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-26 12:13 UTC by Matt McCutchen
Modified: 2009-12-31 16:12 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt McCutchen 2007-06-26 12:13:38 UTC 
Currently, on systems that support lchmod and lutimes, rsync uses them only when it needs to manipulate a symlink.  I think it should use them everywhere in place of chmod and utimes to avoid surprises or vulnerabilities should a destination file of another type be suddenly replaced by a symlink.
Comment 1 Wayne Davison 2009-12-31 16:12:02 UTC 
3.1.0 will always use lchmod() and lutimes() (when available), as you suggest.