Bug 4628 - Build breaks with configure paramenters ./configure --with-acl-support --with-smbwrapper --with-winbind on Tru64
Build breaks with configure paramenters ./configure --with-acl-support --with...
Status: RESOLVED FIXED
Product: Samba 3.0
Classification: Unclassified
Component: Build environment
3.0.25
Alpha Other
: P3 regression
: none
Assigned To: Tim Potter
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-05-17 05:44 UTC by shantala
Modified: 2007-05-18 07:55 UTC (History)
0 users

See Also:


Attachments
Has one line fix which defines smb_acl_permset_t (451 bytes, text/plain)
2007-05-17 05:46 UTC, shantala
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description shantala 2007-05-17 05:44:55 UTC
Hi When building samba-3.0.25 with ./configure --with-acl-support --with-smbwrapper --with-winbind options I am getting the follwoing error


 
Compiling modules/vfs_tru64acl.c
cc: Error: modules/vfs_tru64acl.c, line 31: In this parameter list, "smb_acl_permset_t" must either be a type or must be followed by a ",". (badparseparam)
static acl_perm_t smb_permset_to_tru64(smb_acl_permset_t smb_permset);
---------------------------------------^
cc: Error: modules/vfs_tru64acl.c, line 32: Missing ";". (nosemi)
static smb_acl_permset_t tru64_permset_to_smb(const acl_perm_t tru64_permset);
-------------------------^
cc: Error: modules/vfs_tru64acl.c, line 204: In this declaration, "smb_acl_permset_t" must specify a type. (badparsedecl)
        smb_acl_permset_t smb_permset;
--------^
cc: Error: modules/vfs_tru64acl.c, line 440: In this parameter list, "smb_acl_permset_t" must either be a type or must be followed by a ",". (badparseparam)
static acl_perm_t smb_permset_to_tru64(smb_acl_permset_t smb_permset)
---------------------------------------^
cc: Error: modules/vfs_tru64acl.c, line 459: Missing ";". (nosemi)
static smb_acl_permset_t tru64_permset_to_smb(const acl_perm_t tru64_permset)
-------------------------^
cc: Error: modules/vfs_tru64acl.c, line 461: In this declaration, "smb_acl_permset_t" must specify a type. (badparsedecl)
        smb_acl_permset_t smb_permset  = 0;
--------^




when checked found that smb_acl_permset_t  is no where declared

so adding the follwoing line makes the build go therough


typedef mode_t smb_acl_permset_t;

the actual diff is as follows

$ diff -c vfs_tru64acl.c samba-3.0.25/source/modules/vfs_tru64acl.c
*** vfs_tru64acl.c      Thu May 17 16:11:31 2007
--- samba-3.0.25/source/modules/vfs_tru64acl.c  Thu May 17 16:12:44 2007
***************
*** 20,25 ****
--- 20,26 ----

  #include "includes.h"

+ typedef mode_t smb_acl_permset_t;
  /* prototypes for private functions first - for clarity */

  static struct smb_acl_t *tru64_acl_to_smb_acl(const struct acl *tru64_acl);



regards
Shantala
Comment 1 shantala 2007-05-17 05:46:53 UTC
Created attachment 2700 [details]
Has one line fix which defines smb_acl_permset_t
Comment 2 Björn Jacke 2007-05-17 17:41:02 UTC
this one is already fixed in svn.

Jerry, that patch (r22918) might be one for 3.0.25a
Comment 3 Gerald (Jerry) Carter 2007-05-18 07:55:26 UTC
 Björn, agreed.  I'll ping Michael and ask him to merge to SAMBA_3_0_25.