Bug 4623 - Enumeration constant definition violation
Summary: Enumeration constant definition violation
Status: RESOLVED WONTFIX
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.0.25
Hardware: Sparc Solaris
: P3 normal
Target Milestone: none
Assignee: Jelmer Vernooij
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-16 06:08 UTC by Paul Kranenburg
Modified: 2025-08-08 01:33 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Kranenburg 2007-05-16 06:08:18 UTC 
Enumeration constant definition violation in librpc/gen_ndr/srvsvc.h.
Noticed by compiler e.g. as follows:

line 213: warning: enumerator value overflows INT_MAX

Fix:

9c9
< #define STYPE_HIDDEN  ( 0x80000000 )
---
> #define STYPE_HIDDEN  ( (signed int)0x80000000 )
Comment 1 Dane Butler 2007-11-22 19:22:23 UTC 
Issue also occurs on Tru64 UNIX 5.1a for all versions from 3.0.25 to current (3.0.27a)
Comment 2 Jelmer Vernooij 2008-01-07 13:24:46 UTC 
Thanks for the bug report.
Comment 3 John Center 2009-03-05 07:29:28 UTC 
This still occurs with v3.3.1.
Comment 4 Douglas Bagnall 2025-08-08 01:33:57 UTC 
(In reply to Paul Kranenburg from comment #0)
> Fix:
> 
> 9c9
> < #define STYPE_HIDDEN  ( 0x80000000 )
> ---
> > #define STYPE_HIDDEN  ( (signed int)0x80000000 )

fix is wrong. This is generated code, and is defined as unsigned in librpc/idl/srvsvc.idl:

 const uint32 STYPE_HIDDEN    = 0x80000000;

We could add a UL to the end of that, but I will tentatively WONTFIX under the assumption that Solaris and Tru64 compilers have caught up or otherwise fallen silent.