The Samba-Bugzilla – Bug 4601
smbc_getxattr returns error when buffer size is set to 0
Last modified: 2007-10-20 09:00:02 UTC
Looking at the comments from libsmbclient.h for function smbc_getxattr we can read:
* @param size The size of the buffer pointed to by value. This parameter
* may also be zero, in which case the size of the buffer
* required to hold the attribute value will be returned,
* but nothing will be placed into the value buffer.
however, if we set size parameter to 0, we get -1 returned and errno is set to 34 (Numerical result out of range)
But if we put a buffer with a decent size eg 1024 the function returns the buffer size needed and the ACLs requested in the buffer.
This is a minor bug but wanted to report it.
Created attachment 2688 [details]
likely fix for described problem
A quick look reveals one missing test for whether we are just determining the size. Please try the attached patch and let me know the results.
Looks like we have a winner! =)
Wouldn't be nice if all bugs were this easy to solve?
Good job /henrik
Fixed by check-in 22850, 22851