Bug 4537 - denytest.c:torture_denytest2 accesses wrong array
Summary: denytest.c:torture_denytest2 accesses wrong array
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Client Tools (show other bugs)
Version: 3.0.23d
Hardware: All All
: P3 minor
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-24 05:31 UTC by Jens Nissen
Modified: 2007-08-02 02:48 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Nissen 2007-04-24 05:31:10 UTC 
torture_denytest2 accesses the wrong array denytable1 which may lead to an incorrect display of progress, if in some future release the sizes of the arrays denytable1 and denytable2 differ.

Fix:

diff U3w C:\Projects\samba3\source\torture\denytest.c C:\Projects\samba3\source\torture\Kopie von denytest.c
--- C:\Projects\samba3\source\torture\denytest.c	Tue Apr 24 12:21:54 2007
+++ C:\Projects\samba3\source\torture\Kopie von denytest.c	Tue Apr 17 12:07:37 2007
@@ -1515,7 +1515,7 @@
 		enum deny_result res;
 		const char *fname = fnames[denytable2[i].isexe];
 
-		progress_bar(i, ARRAY_SIZE(denytable1));
+		progress_bar(i, ARRAY_SIZE(denytable2));
 
 		fnum1 = cli_open(cli1, fname, 
 				 denytable2[i].mode1,
Comment 1 Jens Nissen 2007-08-02 02:48:28 UTC 
Fixed in 3.025b