Bug 4518 - mkversion test needs arg quoting
Summary: mkversion test needs arg quoting
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.0.23
Hardware: Other All
: P3 normal
Target Milestone: none
Assignee: Tim Potter
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-16 00:33 UTC by David Leonard (550 5.7.1 Unable to deliver)
Modified: 2019-06-11 21:25 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Leonard (550 5.7.1 Unable to deliver) 2007-04-16 00:33:42 UTC 
when SAMBA_VERSION_VENDOR_SUFFIX is defined, then mkversion.sh tests SAMBA_VENDOR_PATCH but falls over with an error from test because its arg
isn't quoted

    if test -n ${SAMBA_VENDOR_PATCH}; then
       echo -n "-${SAMBA_VENDOR_PATCH}"
   fi
Comment 1 Andrew Bartlett 2019-06-11 10:27:19 UTC 
This is now a part of waf as buildtools/wafsamba/samba_version.py so this is no longer an issue in current supported versions.