Bug 4032 - "show diffs" css too broken for Opera and IE
"show diffs" css too broken for Opera and IE
Status: CLOSED FIXED
Product: Samba Web
Classification: Unclassified
Component: content
unspecified
Other Windows XP
: P3 normal
: ---
Assigned To: Deryck Hodge
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-08-17 16:43 UTC by Björn Jacke
Modified: 2007-10-04 05:59 UTC (History)
1 user (show)

See Also:


Attachments
fix for it (1.05 KB, patch)
2007-10-02 06:17 UTC, Björn Jacke
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2006-08-17 16:43:47 UTC
in IE and Opera 9 (both tested in Windows) just can't handle the part of css which is for displaying the patch sources if you click on "show diffs".
Comment 1 Björn Jacke 2006-10-31 08:48:07 UTC
example link:
http://build.samba.org/?function=diff;tree=samba_3_0;date=1162299476;author=idra;revision=19516
(or any "show diffs" link on the recent checkins site)

Doesn' work with Konqueror, Opera, IE ... only Mozilla-base browsers work.
Comment 2 Paul Green 2007-09-11 11:53:07 UTC
I just tested IE7 on Windows XP+SP2 and it cannot even display the Build Farm home page (http://build.samba.org).  The build-farm script returns a filename of "build_farm_org" which leads IE7 to display a dialog box indicating that the file has an "unknown file type".  If you save the file to disk and rename it so it ends in ".html", then IE7 can access the web page; however, it is unable to display it properly.  Some of the items on the web page overlap each other.  So basically, the build farm is inaccessible from IE7.  I didn't try older versions of IE.
Comment 3 Björn Jacke 2007-10-02 05:18:58 UTC
Paul, can you please open a new bug for that problem as this is not relates to this CSS bug ...
Comment 4 Björn Jacke 2007-10-02 06:17:19 UTC
Created attachment 2935 [details]
fix for it

if web browsers don't see a valid end of a <!--foo--> html comment they don't know when the html code stops babbling around :-)
Comment 5 Björn Jacke 2007-10-02 07:39:55 UTC
now checked in by metze, thanks!
Comment 6 Paul Green 2007-10-02 14:54:45 UTC
Horay!  IE7 works now!  I can load the home page and click on links and the pages load properly and look fine.  Many thanks. PG
Comment 7 Björn Jacke 2007-10-04 05:59:40 UTC
you're welcome. The problem you had with IE was that the page was delivered with Content-Type x-perl instead of text/html.