Bug 397 - valid users doesn't expand %U, %D, etc.
Summary: valid users doesn't expand %U, %D, etc.
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: File Services (show other bugs)
Version: 3.0.0preX
Hardware: All Linux
: P2 normal
Target Milestone: 3.0.0rc3
Assignee: Gerald (Jerry) Carter (dead mail address)
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-03 12:53 UTC by Tom Dickson
Modified: 2005-11-14 09:24 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Dickson 2003-09-03 12:53:56 UTC 
Using the following doesn't work:

[%U]
 path = /mnt/H44//%U
 browseable = yes
 writeable = yes
 preserve case = yes
 valid users = %D+%U
 comment = Home Share
 short preserve case = yes

But changing valid users to write list works, i.e.:

write list = %D+%U

It also fails with %S, etc.

Looking through level 10 logs shows smbd not expanding the macros:

[2003/09/02 15:11:33, 10] lib/username.c:user_in_list(504)
  user_in_list: checking user MIXEDDOMAIN+dl in list
[2003/09/02 15:11:33, 10] lib/username.c:user_in_list(508)
  user_in_list: checking user |MIXEDDOMAIN+dl| against |%s|
[2003/09/02 15:11:33, 2] smbd/service.c:make_connection_snum(384)
  user 'MIXEDDOMAIN+dl' (from session setup) not permitted to access this share (dl)
[2003/09/02 15:11:33, 3] smbd/error.c:error_packet(109)

Logs available if necessary.
Comment 1 Gerald (Jerry) Carter (dead mail address) 2003-09-04 22:10:54 UTC 
confirmed.  This is a bug in user_ok().  Working on a fix.
Comment 2 Gerald (Jerry) Carter (dead mail address) 2003-09-04 22:28:38 UTC 
Fixed in SAMBA_3_0 cvs tree.  See checkins to

   * smbd/password.c
   * lib/util_str.c
Comment 3 Gerald (Jerry) Carter (dead mail address) 2005-02-07 09:05:52 UTC 
originally reported against one of the 3.0.0rc[1-4] releases.
Cleaning up non-production versions.
Comment 4 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:15:56 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.
Comment 5 Gerald (Jerry) Carter (dead mail address) 2005-11-14 09:24:51 UTC 
database cleanup