Bug 3909 - samba tries to look up dos attributes out of msdfs symlinks
Summary: samba tries to look up dos attributes out of msdfs symlinks
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: File Services (show other bugs)
Version: 3.0.23
Hardware: Other Linux
: P3 normal
Target Milestone: none
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-03 08:54 UTC by Björn Jacke
Modified: 2006-07-12 10:38 UTC (History)
0 users

See Also:

Attachments
Patch (2.80 KB, patch)
2006-07-03 15:39 UTC, Jeremy Allison 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2006-07-03 08:54:38 UTC 
dfslink is a symlink to a dfs share (strictly speaking: a dead symlink) and Samba tries to look up dos attributes for it but can't (strore dos attributes ist set and thus getxattr returns no such file for that dead symlink ...)

[2006/07/03 14:24:56, 1] smbd/dosmode.c:get_ea_dos_attribute(227)
  get_ea_dos_attributes: Cannot get attribute from EA on file ./dfslink: Error = No such file or directory
Comment 1 Jeremy Allison 2006-07-03 12:32:27 UTC 
Hmmm. Shouldn't be able to get there....

The code :

        if (!VALID_STAT(*sbuf)) {
                return 0;
        }

should prevent this from getting to the ea code.....

I'll take a look. What were you doing that triggered this ?
I'm guessing this is a code path an uninitialized value of *sbuf,
it would be very interesting to know how you got here.


Jeremy.
Comment 2 Jeremy Allison 2006-07-03 13:06:24 UTC 
Ok I can see how this would happen.....

Jerry - show stopper for 3.0.23. Fix should be today.

Jeremy.
Comment 3 Jeremy Allison 2006-07-03 15:39:05 UTC 
Created attachment 2016 [details]
Patch

Can you test this out please ?
Should fix the problem.
Jeremy.
Comment 4 Björn Jacke 2006-07-12 10:36:45 UTC 
this does not fix that error, still happens with 3.0.23 final.
Comment 5 Björn Jacke 2006-07-12 10:38:54 UTC 
sorry ... tested with rc3, not final. final with this patch is okay! :-)