Bug 3892 - utils/net_util.c: enumerated type is mixed with another type
Summary: utils/net_util.c: enumerated type is mixed with another type
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.0.23
Hardware: SGI IRIX
: P3 normal
Target Milestone: none
Assignee: Tim Potter
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-28 14:26 UTC by Jason Mader (mail bounces back)
Modified: 2006-06-28 16:48 UTC (History)
0 users

See Also:

Attachments
Change type of "types" (332 bytes, patch)
2006-06-28 16:02 UTC, Jason Mader (mail bounces back) 		no flags Details
Change type on rpccli_lsa_lookup_names( ) (867 bytes, patch)
2006-06-28 16:15 UTC, Jason Mader (mail bounces back) 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mader (mail bounces back) 2006-06-28 14:26:23 UTC 
--- utils/net_util.o ---
cc-1185 c99: WARNING File = utils/net_util.c, Line = 79
  An enumerated type is mixed with another type.

                *ret_type = types[0];
                          ^
Comment 1 Jason Mader (mail bounces back) 2006-06-28 16:02:38 UTC 
Created attachment 1997 [details]
Change type of "types"

This makes another warning,

cc-1164 c99: WARNING File = utils/net_util.c, Line = 62
  Argument of type "enum SID_NAME_USE **" is incompatible with parameter of type
          "unsigned int **".

                                         &name, &dom_names, &sids, &types);
                                                                   ^

but the type of "types" matches the other functions - and this put the onus on rpccli_lsa_lookup_names() to change it's argument type.
Comment 2 Jason Mader (mail bounces back) 2006-06-28 16:15:19 UTC 
Created attachment 1998 [details]
Change type on rpccli_lsa_lookup_names( )
Comment 3 Jeremy Allison 2006-06-28 16:48:25 UTC 
I fixed this with the global change to make the lookup_XX rpc calls return enum SID_NAME_TYPE types.
Jeremy.